Add NUPath to sidebar #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Suraj-Ram
reviewed
Feb 27, 2024
| } | ||
| } | ||
|
|
||
| const wiCount = nupathMap[NUPathEnum.WI]; |
There was a problem hiding this comment.
I would make it const wiCount = nupathMap[NUPathEnum.WI] || 0; that way you won't need to check for truthy-ness when checking if wiCount >= 2.
Suraj-Ram
reviewed
Feb 27, 2024
| dndIdPrefix: string; | ||
| loading?: boolean; | ||
| } | ||
| const nuPathDisplayAndAbbr: [ |
There was a problem hiding this comment.
Instead of an array, can we switch this to an Object where the key is NUPathEnum? So it would be a Record<NUPathEnum, string>
There was a problem hiding this comment.
Not doing this to make it easy to iterate over in the component
yijen-sun
reviewed
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Closes #649
Type of change
Please tick the boxes that best match your changes.
yarn installyarn dev:migration:runHow Has This Been Tested?
Adding courses with different NUPaths
Checklist: